RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files [v3]

Weijun Wang weijun at openjdk.java.net
Wed Nov 4 21:08:58 UTC 2020


On Wed, 4 Nov 2020 20:52:11 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Could someone please help review this PKCS#11 v3.0 header files update?
>> 
>> Changes are straight-forward as below:
>> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
>> 2) Updated java side w/ the new constants definitions and name/error code mappings.
>> 
>> For the native headers, it's a direct copy of the official v3.0 headers except that I have to remove the tab space, and trailing white spaces due to JDK code requirement. I verified the result using 'diff -w'. As for the java side, the edit is based on the diff of native headers. I also commented out some of the unused native identifiers at java side.
>> 
>> I am adding the SHA-3 digests, signatures, and macs in a separate RFE and would need this one to be reviewed/integrated first.
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated the javadoc comments of PKCS11Constants class with additional
>   typedef info
>   Updated the legal file to new PKCS11 version

Marked as reviewed by weijun (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/917



More information about the security-dev mailing list