RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

[Anthony Scarpino]

On Wed, 4 Nov 2020 00:46:13 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - style
>>  - style & comments
>>  - full update
>>  - remove old
>>  - update
>>  - outputsize
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 770:
> 
>> 768:         checkDataLength(0, len);
>> 769: 
>> 770:         if ((ibuffer.size() + ct.remaining()) - tagLenBytes >
> 
> ct is set a new limit (minus the tag length) on line 741. So this check seems incorrect?
> How about using the 'len' value which seems to be the overall input size which should also be the expected output size?

Yeah, I'd agree

> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 746:
> 
>> 744:                 len += buffer.remaining();
>> 745:             }
>> 746:             ct.mark();
> 
> This seems redundant given the ct.mark() call on line 732?

Does seem redundant.. I'll remove and see how testing goes

-------------

PR: https://git.openjdk.java.net/jdk/pull/411