RFR: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU

Fernando Guallini fguallini at openjdk.java.net
Fri Nov 6 12:38:05 UTC 2020


This patch is to add code coverage to the following methods
- javax.smartcardio.CardPermission::**implies** (1)
- javax.smartcardio.ResponseAPDU::**toString** (2)

Tests are added following the expected implementation given in the methods specifications

(1) https://github.com/openjdk/jdk/blob/5dfb42fc68099278cbc98e25fb8a91fd957c12e2/src/java.smartcardio/share/classes/javax/smartcardio/CardPermission.java#L214-L229

(2) https://github.com/openjdk/jdk/blob/5dfb42fc68099278cbc98e25fb8a91fd957c12e2/src/java.smartcardio/share/classes/javax/smartcardio/ResponseAPDU.java#L141-L149

-------------

Commit messages:
 - refactor smartcardio test in order to be more comprehensive
 - add code coverage for CardPermission.implies and ResponseAPDU.toString

Changes: https://git.openjdk.java.net/jdk/pull/1092/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1092&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255546
  Stats: 122 lines in 2 files changed: 82 ins; 12 del; 28 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1092.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1092/head:pull/1092

PR: https://git.openjdk.java.net/jdk/pull/1092



More information about the security-dev mailing list