RFR: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU

[Fernando Guallini]

On Fri, 6 Nov 2020 12:04:20 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

> This patch is to add code coverage to the following methods
> - javax.smartcardio.CardPermission::**implies** (1)
> - javax.smartcardio.ResponseAPDU::**toString** (2)
> 
> Tests are added following the expected implementation given in the methods specifications
> 
> (1) https://github.com/openjdk/jdk/blob/5dfb42fc68099278cbc98e25fb8a91fd957c12e2/src/java.smartcardio/share/classes/javax/smartcardio/CardPermission.java#L214-L229
> 
> (2) https://github.com/openjdk/jdk/blob/5dfb42fc68099278cbc98e25fb8a91fd957c12e2/src/java.smartcardio/share/classes/javax/smartcardio/ResponseAPDU.java#L141-L149

> _Mailing list message from [sibabrata.sahoo at oracle.com](mailto:sibabrata.sahoo at oracle.com) on [security-dev](mailto:security-dev at openjdk.java.net):_
> 
> So you have converted the Test to use JUnit other than adding few new Test cases.
> 
> It looks fine to me.
> 
> Thanks,
> Siba

Hi Siba,
Tests were converted to Testng and coverage for CardPermission::implies and ResponseAPDU::toString was added. Thank you for reviewing

-------------

PR: https://git.openjdk.java.net/jdk/pull/1092