RFR: 8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()

[Weijun Wang]

On Tue, 10 Nov 2020 11:37:04 GMT, Prajwal Kumaraswamy <github.com+70745465+pkumaraswamy at openjdk.org> wrote:

> …ineResolveURI().
> 
> Actual fix looks like this, due to git diff there are lot  of changes( mostly because of the spaces) being displayed.
> 
> --- a/src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java
> +++ b/src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java
> @@ -500,6 +500,7 @@
>                  }
>  
>                  boolean secVal = Utils.secureValidation(context);
> +                try {
>                  xi.setSecureValidation(secVal);
>                  if (context instanceof XMLSignContext && c14n11
>                      && !xi.isOctetStream() && !xi.isOutputStreamSet()) {
> @@ -533,6 +534,11 @@
>                  } else {
>                      xi.updateOutputStream(os);
>                  }
> +                } finally {
> +                    if(xi.getOctetStreamReal() != null) {
> +                        xi.getOctetStreamReal().close();
> +                    }
> +                }
>              }

Marked as reviewed by weijun (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1142