RFR: 8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest

Matthias Baesken mbaesken at openjdk.java.net
Thu Nov 12 06:46:55 UTC 2020


On Wed, 11 Nov 2020 14:36:07 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Working on 11u backports of JDK-8218021 and JDK-8250968, I found some minor points for improvement in tests
> test/jdk/sun/security/tools/jarsigner/PosixPermissionsTest.java and
> test/jdk/sun/security/tools/jarsigner/SymLinkTest.java
> 
> The details
> 
> PosixPermissionsTest:
> - it can run on any system, no matter if the default filesystem supports Posix or not since Posix support is only required for the zipfs which is always true.
> - improve some comments for the test flow
> 
> SymLinkTest:
> - make output of createByteArray prettier
> - improve inline comments to ease understanding
> - add an option to main for generating ZIPBYTES
> - use "Files.write(Path.of(ZIPFILENAME), ZIPBYTES)" for creating the test zipfile

Marked as reviewed by mbaesken (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1166



More information about the security-dev mailing list