RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v18]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Thu Nov 12 18:07:23 UTC 2020
On Wed, 11 Nov 2020 14:18:33 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with 10 additional commits since the last revision:
>>
>> - Merge pull request #7 from JornVernee/Additional_Review_Comments
>>
>> Additional review comments
>> - Revert System.java changes
>> - Set copyright year for added files to 2020
>> - Check result of AttachCurrentThread
>> - Sort includes alphabetically
>> - Relax ret_addr_offset() assert
>> - Extra space after if
>> - remove excessive asserts in ProgrammableInvoker::invoke_native
>> - Remove os::is_MP() check
>> - remove blank line in thread.hpp
>
> I made a pass over hotspot code. Overall, it looks good. Some comments follow.
I've just merged against master - which now contains the foreign memory API changes that this JEP depends on. I believe reviewing the changes should now be easier, as only the relevant changes should be presented in the "File Changed" tab.
-------------
PR: https://git.openjdk.java.net/jdk/pull/634
More information about the security-dev
mailing list