RFR: 8253821: Improve ByteBuffer performance with GCM [v4]

[Valerie Peng]

On Thu, 12 Nov 2020 16:34:30 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Code review comment update
>   Major change to test to detect corruption with incremental buffers test

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 518:

> 516:             ArrayUtil.nullAndBoundsCheck(out, outOfs, inLen);
> 517:             byte[] block = new byte[blockSize];
> 518:             int inLenUsed = constructBlock(ibuffer.toByteArray(), in, block);

constructBlock takes 'in' but not 'inOfs'? Wouldn't the data be taken from the wrong index? No test catches this, strange?

-------------

PR: https://git.openjdk.java.net/jdk/pull/411