RFR: 8253821: Improve ByteBuffer performance with GCM [v4]
Valerie Peng
valeriep at openjdk.java.net
Fri Nov 13 20:51:04 UTC 2020
On Thu, 12 Nov 2020 16:34:30 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>
> Code review comment update
> Major change to test to detect corruption with incremental buffers test
src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 540:
> 538: // remainder offset is based on original buffer length
> 539: ibuffer.write(in, inOfs + inLen, remainder);
> 540: }
I wonder if this can be moved down for better readability, i.e. process data in multiple of blocks, and store the remaining into 'ibuffer'?
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
More information about the security-dev
mailing list