RFR: 8253821: Improve ByteBuffer performance with GCM [v4]

Valerie Peng valeriep at openjdk.java.net
Fri Nov 13 20:57:05 UTC 2020


On Thu, 12 Nov 2020 16:34:30 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Code review comment update
>   Major change to test to detect corruption with incremental buffers test

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 507:

> 505:         processAAD();
> 506:         // 'len' stores the length to use with buffer 'in'.
> 507:         // 'inLen' stores the length returned by the method.

line 551 has "return len;" which seems conflicting with these two-line comments here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list