RFR: JDK-8166596: TLS support for the EdDSA signature algorithm

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Tue Nov 17 23:45:12 UTC 2020


On Tue, 17 Nov 2020 23:31:13 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> I don't think there's any reason why we could use a Collection<SSLSocketTemplate.Cert> for these.  I'll try switching to that.
>
> Xuelei, I went back and looked at my rationale for using Strings here.  The reason I went with this approach was so I could have client and server parameter maps of <ParamType, String>.  I had a common form for parameters that I'd want to set/reset/change between each type of test run.  If I were to go with something like a Collection<SSLSocketTemplate.Cert> then my client and server parameter maps would end up needing to be <ParamType, Object> and then I'd have to cast based on the param type.  Not sure if changing from the Strings ends up being more clear int the long run.

No problem, using String is ok to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1197



More information about the security-dev mailing list