RFR: 8253821: Improve ByteBuffer performance with GCM [v4]

Valerie Peng valeriep at openjdk.java.net
Thu Nov 19 21:39:14 UTC 2020


On Wed, 18 Nov 2020 05:14:11 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 560:
>> 
>>> 558:             System.arraycopy(buffer, 0, block, 0, blockSize);
>>> 559:             buflen -= block.length;
>>> 560:             return 0;
>> 
>> Will bufLen > blockSize? Judging from the context of this method, buffer.length should always <= blockSize and  never be larger? If bufLen == blockSize, perhaps we can just use buffer directly and no need to copy.
>
> This method is being removed

Ok.

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list