RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]
Jim Laskey
jlaskey at openjdk.java.net
Thu Nov 26 15:36:03 UTC 2020
On Wed, 25 Nov 2020 14:10:17 GMT, Rémi Forax <github.com+828220+forax at openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8248862: Implement Enhanced Pseudo-Random Number Generators
>>
>> Changes to RandomGeneratorFactory requested by @PaulSandoz
>
> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java line 497:
>
>> 495: ensureConstructors();
>> 496: return ctorLong.newInstance(seed);
>> 497: } catch (Exception ex) {
>
> this one is very dubious because the result in an exception is thrown is a random generator with the wrong seed
This is explained in the docs.
> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java line 480:
>
>> 478: } catch (Exception ex) {
>> 479: // Should never happen.
>> 480: throw new IllegalStateException("Random algorithm " + name() + " is missing a default constructor");
>
> chain the exception ...
agree
-------------
PR: https://git.openjdk.java.net/jdk/pull/1292
More information about the security-dev
mailing list