RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v2]

[Bradford Wetmore]

On Thu, 26 Nov 2020 17:41:23 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor grammar error
>
> src/java.base/share/classes/sun/security/provider/SecureRandom.java line 78:
> 
>> 76:      *
>> 77:      * <p>The first time this constructor is called in a given Virtual Machine,
>> 78:      * it may take several seconds of CPU time to seed the generator, depending
> 
> In my understanding this is not true. The constructor will finish in no time, it's the first engineBytes() call that will take several seconds. We may say "this auto seeding process will...".

Are you talking about the line 78?  Yes, you are correct, I didn't update anything beyond the initial comment.  I can update that as well.

> src/java.base/share/classes/sun/security/provider/SecureRandom.java line 68:
> 
>> 66: 
>> 67:     /**
>> 68:      * This empty constructor.
> 
> How about "An empty constructor that creates an unseeded SecureRandom object"?

Sure, that sounds great.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1461