RFR: 8249783: Simplify DerValue and DerInputStream [v3]

[Weijun Wang]

On Thu, 1 Oct 2020 02:24:47 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since
>> the last revision:
>>  - 8249783: Simplify DerValue and DerInputStream
>>  - Merge remote-tracking branch 'origin/master' into 8249783
>>  - Enhance DerValue::getOctetString to be able to read multi-level constructed value.
>>  - 8249783: Simplify DerValue and DerInputStream
>
> Updated webrev looks fine. Only a minor nit regarding a comment remaining.

Added a new commit. Mostly comment or style change. Several always-false `if (lenByte < 0)` check removed.
`result.toArray(new DerValue[0])` used because new knowledge shows it's faster than `result.toArray(new
DerValue[result.size()])`. `getSet(int,boolean implicit)` added check for `implicit` to be semantically correct
(although it's always called with `implicit == true`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/232