RFR: 8253952: Refine ZipOutputStream.putNextEntry() to ignore ZipEntry's compressed size

Volker Simonis simonis at openjdk.java.net
Wed Oct 7 16:48:14 UTC 2020


On Wed, 7 Oct 2020 15:34:32 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 97:
>> 
>>> 95:      * and re-compute its value automatically after the associted data has been
>>> 96:      * completely deflated.
>>> 97:      *
>> 
>> We probably need to do a bit wordsmithing here.
>> 
>> I think I'd drop the first two sentences and instead start a new paragraph here (<p> tag) with "Unless explicitly set,
>> the output stream will ignore ..." and see how that looks.
>> Probably should be "the ZipEntry" rather than "a ZipEntry" to be consistent with the parameter description.
>
> Alan makes a good point.  Perhaps we keep things simple and focus solely on tweaking the description of the change in
> behavior which is described in your last paragraph

I totally agree. What about using just the last sentence (as you've proposed) in the spec section and add the other to
as @implNote? O you think the last sentence will be enough?

-------------

PR: https://git.openjdk.java.net/jdk/pull/520



More information about the security-dev mailing list