RFR: 8242882: opening jar file with large manifest might throw NegativeArraySizeException [v2]
Jaikiran Pai
jpai at openjdk.java.net
Thu Oct 8 06:55:32 UTC 2020
On Wed, 7 Oct 2020 21:40:43 GMT, Brent Christian <bchristi at openjdk.org> wrote:
>> I decided to slightly change the way this large manifest file was being created. I borrowed the idea from
>> `Zip64SizeTest`[1] to create the file and set its length to a large value. I hope that is OK. If not, let me know, I
>> will change this part. [1]
>> https://github.com/openjdk/jdk/blob/master/test/jdk/java/util/zip/ZipFile/Zip64SizeTest.java#L121
>
> I did some automated test runs, and the duration of this test is sufficiently improved, IMO.
>
> While not representative of a real MANIFEST.MF file, I think it works well enough for this specific test.
Thank you for the review Brent.
-------------
PR: https://git.openjdk.java.net/jdk/pull/323
More information about the security-dev
mailing list