RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Oct 8 13:49:47 UTC 2020


On Thu, 8 Oct 2020 12:54:12 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> make/modules/java.base/gensrc/GensrcScopedMemoryAccess.gmk line 145:
> 
>> 143: SCOPE_MEMORY_ACCESS_TYPES := Byte Short Char Int Long Float Double
>> 144: $(foreach t, $(SCOPE_MEMORY_ACCESS_TYPES), \
>> 145: 	  $(eval $(call GenerateScopedOp,BIN_$t,$t)))
> 
> This indent was fine at 2 spaces.  I meant the one below inside the recipe.

Gotcha - I fixed the wrong foreach...

-------------

PR: https://git.openjdk.java.net/jdk/pull/548



More information about the security-dev mailing list