RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Fri Oct 9 04:46:23 UTC 2020


On Fri, 9 Oct 2020 03:20:40 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 635:
> 
>> 633:         dst.put(block, 0, tagLenBytes);
>> 634:
>> 635:         return (processed + tagLenBytes);
> 
> Is it supposed to return "all data processed + tag len"? Normally, we return the output size produced by this
> particular call instead of all accumulated.

Yes, that should be len + tagLenBytes.  We obviously don't check that in our tests

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list