RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

[Daniel Fuchs]

On Fri, 9 Oct 2020 08:49:54 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8229867: Re-examine synchronization usages in http and https protocol handlers
>>   
>>   Incorporated review feedback
>
> src/java.base/share/classes/sun/net/www/http/KeepAliveStream.java line 69:
> 
>> 67:     public void close() throws IOException  {
>> 68:         // If the inputstream is closed already, or if this stream
>> 69:         // has already been queued for cleanup.just return.
> 
> Minor typo, "cleanup.just"

done

> src/java.base/share/classes/sun/net/www/MessageHeader.java line 330:
> 
>> 328:         at the end. Omits pairs with a null key. Omits
>> 329:         colon if key-value pair is the requestline. */
>> 330:     private  void print(int nkeys, String[] keys, String[] values, PrintStream p) {
> 
> While not strictly necessary, this method (along with isRequestline) could be _static_. Which ensures that their
> implementations do not access instance fields.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/558