RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

[Daniel Fuchs]

On Fri, 9 Oct 2020 13:22:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8229867: Re-examine synchronization usages in http and https protocol handlers
>>   
>>   Incorporated review feedback
>
> src/java.base/share/classes/sun/net/www/http/HttpCapture.java line 59:
> 
>> 57:     // Although accessing files could result in blocking operations,
>> 58:     // HttpCapture is a corner case; there seem no urgent need to convert
>> 59:     // this class to using java.util.concurrent.locks at this time.
> 
> The updated patch looks good but I think this comment needs another iteration to ensure that it doesn't confuse future
> maintainers. You could drop it or else replace it with something simple that says that HttpCapture does blocking I/O
> operations while holding monitors but it's not a concern because it rarely used.

Updated as requested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/558