RFR: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size [v4]

Lance Andersen lancea at openjdk.java.net
Tue Oct 13 16:59:17 UTC 2020


On Wed, 7 Oct 2020 17:04:02 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> I totally agree. What about using just the last sentence (as you've proposed) in the spec section and add the other to
>> as @implNote? O you think the last sentence will be enough?
>
> I think we can just go with the last sentence/paragraph.  Perhaps  we can further simplify the  paragraph/sentence with
> something like:
> The compressed entry size will be recalculated  for compressed (DEFLATED) entries when  ZipEntry::setCompressedSize has
> not been explicitly called on the ZipEntry.
> or
> 
> The compressed (DEFLATED) entry size will be recalculated when  ZipEntry::setCompressedSize has not been explicitly
> called on the ZipEntry.

I think the wording looks much better now

-------------

PR: https://git.openjdk.java.net/jdk/pull/520



More information about the security-dev mailing list