RFR: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size [v6]

[Volker Simonis]

On Tue, 13 Oct 2020 19:56:50 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Volker Simonis has refreshed the contents of this pull request, and previous commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
> test/jdk/java/util/zip/CopyZipFile.java line 104:
> 
>> 102:         // all these fields set to '-1'.
>> 103:         InputStream is = new FileInputStream(ZIP_FILE);
>> 104:         ZipInputStream zis = new ZipInputStream(is);
> 
> Any reason not to include the the ZipInputStream and InputStream in the try with Resources and the ZipFile below?  I
> know these are nits, but just curious or was it an over site?
> I think we are good otherwise

No other reason except my laziness :)

> test/jdk/java/util/zip/CopyZipFile.java line 140:
> 
>> 138:         // This means that all ZipEntry objects returned from ZipFile will have correct
>> 139:         // settings for these fields.
>> 140:         // I the compression level was different in the initial zip file (which we can't find
> 
> typo I -> If

Fixed

> test/jdk/java/util/zip/CopyZipFile.java line 188:
> 
>> 186:                     if ("test1.txt".equals(entry.getName()) || "test2.txt".equals(entry.getName())) {
>> 187:                         throw new Exception(
>> 188:                             "Should throw for STORED files or files compressed with DEFAULT_COMPRESSION");
> 
> Perhaps clean up the message above "Should throw" to indicate what is being thrown

Thanks. That should actually red "Shouldn't...". Fixed that and also added ZipExcpetion as exception which shouldn't be
thrown.

-------------

PR: https://git.openjdk.java.net/jdk/pull/520