RFR: 8242068: Signed JAR support for RSASSA-PSS and EdDSA [v7]

Weijun Wang weijun at openjdk.java.net
Fri Oct 16 02:23:17 UTC 2020


On Wed, 14 Oct 2020 19:18:04 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   signing time, jarsigner -directsign, and digest algorithm check
>
> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 172:
> 
>> 170:         throws IOException
>> 171:     {
>> 172:         ContentInfo block = new ContentInfo(derin, oldStyle);
> 
> With this change, i.e. using a local variable instead of setting the field 'contentInfo', the 'contentInfo' field seems
> to left unset when contentType equals to ContentInfo.NETSCAPE_CERT_SEQUENCE_OID?

I'll see what the best code is, but I don't like the way contentInfo is assigned twice, once as the whole block and
once as the content inside. I'd rather add a `contentInfo = block` in its else if block.

-------------

PR: https://git.openjdk.java.net/jdk/pull/322



More information about the security-dev mailing list