RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v10]
Fei Yang
fyang at openjdk.java.net
Wed Oct 21 09:10:57 UTC 2020
On Tue, 20 Oct 2020 23:06:41 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Fix trailing whitespace issue reported by jcheck
>> - Merge master
>> - Merge master
>> - Remove unnecessary code changes in vm_version_aarch64.cpp
>> - Merge master
>> - Merge master
>> - Merge master
>> - Merge master
>> - Add sha3 instructions to cpu/aarch64/aarch64-asmtest.py and regenerate the test in assembler_aarch64.cpp:asm_check
>> - Rebase
>> - ... and 3 more: https://git.openjdk.java.net/jdk/compare/cdc8c401...d32c8ad7
>
> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java line 604:
>
>> 602: add(ignore, "sun/security/provider/SHA5." + shaCompressName + "([BI)V");
>> 603: }
>> 604: add(toBeInvestigated, "sun/security/provider/SHA3." + shaCompressName + "([BI)V");
>
> This should be under `if (isJDK16OrHigher())` check. Something like this:
> https://github.com/openjdk/jdk/pull/650/files#diff-d1f378fc1b7fe041309e854d40b3a95a91e63fdecf0ecd9826b7c95eaeba314eR527
> You can wait when Aleksey push it and update your changes
OK. Will update with the following change after Aleksey's PR is integrated:
--- a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
+++ b/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
@@ -608,6 +608,10 @@ public class CheckGraalIntrinsics extends GraalTest {
if (!config.useSHA512Intrinsics()) {
add(ignore, "sun/security/provider/SHA5." + shaCompressName + "([BI)V");
}
+
+ if (isJDK16OrHigher()) {
+ add(toBeInvestigated, "sun/security/provider/SHA3." + shaCompressName + "([BI)V");
+ }
}
-------------
PR: https://git.openjdk.java.net/jdk/pull/207
More information about the security-dev
mailing list