RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v10]

[Vladimir Kozlov]

On Wed, 21 Oct 2020 09:19:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

> > Someone in Oracle have to run tier1-tier3 testing with these changes to make sure nothing is broken. I don't want to repeat 8254790.
> 
> That's appreciated.
> On my side, I run tier1-tier3 both on aarch64 linux and x86_64 linux.
> The test result on these two platforms looks good for the latest changes.

I started testing of 09: version.

>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java line 604:
>> 
>>> 602:             add(ignore, "sun/security/provider/SHA5." + shaCompressName + "([BI)V");
>>> 603:         }
>>> 604:         add(toBeInvestigated, "sun/security/provider/SHA3." + shaCompressName + "([BI)V");
>> 
>> This should be under `if (isJDK16OrHigher())` check. Something like this:
>> https://github.com/openjdk/jdk/pull/650/files#diff-d1f378fc1b7fe041309e854d40b3a95a91e63fdecf0ecd9826b7c95eaeba314eR527
>> You can wait when Aleksey push it and update your changes
>
> OK.  Will update with the following change after Aleksey's PR is integrated:
> 
> --- a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
> +++ b/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
> @@ -608,6 +608,10 @@ public class CheckGraalIntrinsics extends GraalTest {
>          if (!config.useSHA512Intrinsics()) {
>              add(ignore, "sun/security/provider/SHA5." + shaCompressName + "([BI)V");
>          }
> +
> +        if (isJDK16OrHigher()) {
> +            add(toBeInvestigated, "sun/security/provider/SHA3." + shaCompressName + "([BI)V");
> +        }
>      }

Yes, please, do that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/207