RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

[Maurizio Cimadamore]

On Tue, 20 Oct 2020 21:31:17 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into 8254231_linker
>>  - Fix incorrect capitalization in one copyright header
>>  - Update copyright years, and add classpath exception to files that were missing it
>>  - Use separate constants for native invoker code size
>>  - Re-add file erroneously deleted (detected as rename)
>>  - Re-add erroneously removed files
>>  - Merge branch 'master' into 8254231_linker
>>    
>>    - Fix tests
>>  - Fix more whitespaces
>>  - Fix whitespaces
>>  - Remove rejected file
>>  - ... and 15 more: https://git.openjdk.java.net/jdk/compare/cb6167b2...502bd980
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 126:
> 
>> 124:      *
>> 125:      * @param symbol   downcall symbol.
>> 126:      * @param type     the method type.
> 
> s/method type/carrier type ?

Not sure about this one? E.g. in my mental model, I often have seen "carrier type" associated with j.l.Class ?

> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 139:
> 
>> 137:      *
>> 138:      * <p>The returned segment is <em>not</em> thread-confined, and it only features
>> 139:      * the {@link MemorySegment#CLOSE} access mode. When the returned segment is closed,
> 
> Implying that it is shared? If so might be better to state that directly (with a link), and can be closed explicitly or left until can be collected by the GC?

`The returned segment is <em>not</em> thread-confined` ? Since it features CLOSE, it can be closed explicitly - I'm not sure 100% of what additional clarification is required - but I'm happy to make this clearer (I need more info).

-------------

PR: https://git.openjdk.java.net/jdk/pull/634