RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Thu Oct 22 18:15:16 UTC 2020


On Mon, 12 Oct 2020 17:35:48 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 146:
> 
>> 144:     private static final int MAX_LEN = 1024;
>> 145: 
>> 146:     int doFinal(ByteBuffer src, ByteBuffer dst) throws IllegalBlockSizeException {
> 
> Conventionally, we put doFinal() method after update() method. Perhaps can we reorder it in the same way?

ok

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list