RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v2]

Vladimir Kozlov kvn at openjdk.java.net
Sat Sep 12 00:21:29 UTC 2020


On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:

>> Hello, newbie here
>> 
>> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>> 
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
>> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
>>   imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
>> - All tier1 tests pass.
>> - One jpackage/jlink tier2 test fails but I don't believe it is related.
>> - Some tier3 Swing tests fail but I don't think they are related.
>
> Philippe Marschall has refreshed the contents of this pull request, and previous commits have been removed. The
> incremental views will show differences compared to the previous content of the PR.

Marked as reviewed by kvn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/45



More information about the security-dev mailing list