RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

Yangfei (Felix) felix.yang at huawei.com
Mon Sep 21 02:59:47 UTC 2020


Hi,

> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-retn at openjdk.java.net] On Behalf
> Of Andrew Haley
> Sent: Friday, September 18, 2020 9:48 PM
> To: Fei Yang <fyang at openjdk.java.net>; hotspot-dev at openjdk.java.net;
> security-dev at openjdk.java.net
> Subject: Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic
> 
> On 17/09/2020 05:26, Fei Yang wrote:
> > For now, this feature will not be enabled automatically for aarch64.
> > We can auto-enable this when it is fully tested on real hardware.  But
> > for the above testing purposes, this is auto-enabled when the
> corresponding hardware feature is detected.
> 
> Given that there's no real hardware, it's extra-important to add the new
> instructions to cpu/aarch64/aarch64-asmtest.py and regenerate the test in
> assembler_aarch64.cc:asm_check.

I have added on commit in PR resolving this: https://github.com/openjdk/jdk/pull/207/commits/04bdb42e971aa1c2f78bb5c916db62910e167053?file-filters%5B%5D= 
I grouped SHA512SIMDOp, SHA3SIMDOp and SVEVectorOp after the # ARMv8.2A comment.  So anticipate more changes in file assembler_aarch64.cpp.

BTW:
If this feature is not auto-enabled when the SHA3 hardware feature is there, we will have one failure for the following test:
test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java
 15 #-----testresult-----
 16 description=file\:/home/yangfei/github/jdk/test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java
 17 elapsed=31546 0\:00\:31.546
 18 end=Mon Sep 21 10\:27\:58 CST 2020
 19 environment=regtest
 20 execStatus=Failed. Execution failed\: `main' threw exception\: java.lang.AssertionError\: Option 'UseSHA3Intrinsics' is expected to have 'true' value Option 'UseSHA3Intrinsics' should be enabled by default

Any suggestions for this?

Thanks,
Felix


More information about the security-dev mailing list