RFR: 8249783: Simplify DerValue and DerInputStream [v2]

Weijun Wang weijun at openjdk.java.net
Sat Sep 26 01:00:11 UTC 2020


On Fri, 18 Sep 2020 21:25:28 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> This code change rewrites DerValue into a mostly immutable class and simplifies DerInputStream as a wrapper for a
>> series of DerValues objects. DerInputBuffer is removed.
>> All existing methods of DerValue and DerInputStream should still work with the exact same behavior, except for a few
>> places where bugs are fixed. For example, Indefinite length must be used with a constructed tag.
>> Except for the ObjectIdentifier class where DerInputBuffer is directly referenced, no other code is touched.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enhance DerValue::getOctetString to be able to read multi-level constructed value.

Thanks a lot for your detailed code review. I'll push a new commit early next week.

-------------

PR: https://git.openjdk.java.net/jdk/pull/232



More information about the security-dev mailing list