RFR: 8249783: Simplify DerValue and DerInputStream [v2]

Valerie Peng valeriep at openjdk.java.net
Tue Sep 29 00:16:02 UTC 2020


On Fri, 25 Sep 2020 22:47:42 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/util/DerInputStream.java line 69:
>> 
>>> 67:     int mark;
>>> 68:
>>> 69:     public DerInputStream(byte[] data, int start, int length, boolean allowBER) {
>> 
>> Add javadoc for the new impl? Do we need to validate things like data != null, start and length have valid values? Or
>> assuming that since all its callers are internal, no need to check.
>
> I don't intend to add any check because callers are internal. I can add a comment.

Add a comment is good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/232



More information about the security-dev mailing list