RFR: 8260693: Provide the support for specifying a signer in keytool -genkeypair [v2]

Weijun Wang weijun at openjdk.java.net
Thu Apr 1 16:46:22 UTC 2021


On Thu, 1 Apr 2021 16:25:13 GMT, Hai-May Chao <hchao at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java line 114:
>> 
>>> 112:     }
>>> 113: 
>>> 114:     /**
>> 
>> The original constructor can be modified to call `this(keyType,sigAlg,providerName,null,null)`. This is also a good time to modify `public CertAndKeyGen (String keyType, String sigAlg)` to call `this(keyType,sigAlg,null)`. Also please simplify the method javadoc.
>
> Updated the original constructor to call `this(keyType,sigAlg,providerName,null,null)` and its comment block. But leave another original constructor `public CertAndKeyGen (String keyType, String sigAlg)` unchanged, because it does not have `providerName` and `NoSuchProviderException` should not be declared like other constructors.

You're right.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3281



More information about the security-dev mailing list