RFR: 8264606: More comment for ECDH public key validation [v2]

Bradford Wetmore wetmore at openjdk.java.net
Fri Apr 2 14:45:22 UTC 2021


On Fri, 2 Apr 2021 04:14:44 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Improve the readability by adding more comments in the ECDH public key validation implementation in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo correct of unmapable character in the comment line

Marked as reviewed by wetmore (Reviewer).

src/jdk.crypto.ec/share/classes/sun/security/ec/ECDHKeyAgreement.java line 164:

> 162:     }
> 163: 
> 164:     // Check whether a public key is valid, following the ECC

Coding conventions used to be /* */ for method description and multiline comments.

Otherwise, this work is much appreciated for any maintainers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3313



More information about the security-dev mailing list