RFR: 8262316: Reducing locks in RSA Blinding [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Fri Apr 2 19:56:58 UTC 2021


> Hi,
> 
> I need a review of the locking change to the RSA blinding code. The problem was reported that multithreaded performance suffered because there was one global lock on the many blindings operation.  The change reduces locking by using a ConcurrentLinkedQueue to store the different BlindingParameters that other threads maybe using.  The queue size is limited to prevent sudden surges in stored BlindingParameters and a WeakHashMap is still used so the objects can be freed when no longer used.  Performance doubles under high load.
> 
> thanks
> 
> Tony

Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:

  Better handle the comparing of ONE and ZERO

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3296/files
  - new: https://git.openjdk.java.net/jdk/pull/3296/files/3b054789..e948ecac

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3296&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3296&range=00-01

  Stats: 13 lines in 1 file changed: 1 ins; 1 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3296.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3296/head:pull/3296

PR: https://git.openjdk.java.net/jdk/pull/3296



More information about the security-dev mailing list