RFR: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding

Martin Balao mbalao at openjdk.java.net
Tue Apr 6 18:33:44 UTC 2021


On Wed, 17 Feb 2021 12:22:55 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Hi,
>> 
>> I'd like to propose a fix for JDK-8261355 [1].
>> 
>> The scheme used for holding data and padding while performing encryption operations is almost the same than the existing one for decryption. The only difference is that encryption does not require a block-sized buffer to be always held because there is no need, upon an update call, to determine which bytes are real output for the caller and which are padding -as it's required for decryption-. I added a couple of comments in implUpdate to explain this.
>> 
>> No regressions observed in jdk/sun/security/pkcs11.
>> 
>> Thanks,
>> Martin.-
>> 
>> --
>> [1] - https://bugs.openjdk.java.net/browse/JDK-8261355
>
> I will take a look.
> Thanks~

@valeriepeng please take a look at my comments in-line and the new proposal here: https://github.com/openjdk/jdk/pull/2510/commits/b47c03edff1f48b925a67203102385470ac1afdc

Thanks,
Martin.-

-------------

PR: https://git.openjdk.java.net/jdk/pull/2510



More information about the security-dev mailing list