RFR: 8264681: Use the blessed modifier order in java.security
Sean Mullan
mullan at openjdk.java.net
Thu Apr 8 17:07:07 UTC 2021
On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt <github.com+76791+alblue at openjdk.org> wrote:
> 8264681: Use the blessed modifier order in java.security
The rest looks fine, but I would double-check all the copyrights to see if you are modifying any other 3rd-party code than the ones I commented on. Best to leave that code as-is and fix it at the source, if possible.
src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java line 390:
> 388: }
> 389:
> 390: public abstract PSSParameterSpec getPSSParameterSpec();
This is 3rd-party (Apache) code. It would be better to change this at Apache. I would leave this one out.
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Constants.java line 53:
> 51:
> 52: /**
> 53: * This class holds only static final member variables that are constants
Probably best to leave this file unchanged as it is 3rd-party code.
-------------
Marked as reviewed by mullan (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3338
More information about the security-dev
mailing list