RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v6]

Weijun Wang weijun at openjdk.java.net
Tue Apr 13 18:16:31 UTC 2021


On Tue, 13 Apr 2021 17:07:19 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spec clarification
>
> src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/SignatureMethod.java line 247:
> 
>> 245:      * as the signature algorithm, the default parameter as defined in
>> 246:      * <a href="https://tools.ietf.org/html/rfc6931#section-2.3.9">RFC 6931 Section 2.3.9</a>
>> 247:      * is used and this default parameter will also be returned by the
> 
> WE should mention/link to the type returned. Suggest breaking this into two sentences: 
> 
> `If the {@code params} parameter is {@code null} when calling {@link XMLSignatureFactory#newSignatureMethod} with {@code RSA_PSS} as the signature algorithm, the default parameter as defined in <a href="https://tools.ietf.org/html/rfc6931#section-2.3.9">RFC 6931 Section 2.3.9</a> is used. This default parameter is represented as an {@link RSAPSSParameterSpec} type and returned by the {@link SignatureMethod#getParameterSpec()} method.`

OK, and some other tweaks. New commit pushed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3181



More information about the security-dev mailing list