RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

Valerie Peng valeriep at openjdk.java.net
Thu Apr 15 18:25:36 UTC 2021


On Wed, 14 Apr 2021 17:37:00 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> This is a simple Test to add few additional API coverage for all java supported key types. The objective of this Test is to cover equals() and hashcode() methods for each key types.
>
> Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comment changed.
>   
>   Comment changed.

test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 114:

> 112:         HmacSHA384("HmacSHA384"),
> 113:         HmacSHA512("HmacSHA512"),
> 114:         RC2("RC2");

Just curious, how are these decided? Should this be an exhaustive list or just enough sampling for code coverage? If this is meant to be a general test, have you tried to not hardcoding the algorithm names to be enum? Otherwise, new algorithms will not be tested if not updating this test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3490



More information about the security-dev mailing list