RFR: 8185127: Add Tests to cover hashCode() method for java supported crypto key types. [v2]

Valerie Peng valeriep at openjdk.java.net
Thu Apr 15 18:35:34 UTC 2021


On Thu, 15 Apr 2021 18:18:07 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment changed.
>>   
>>   Comment changed.
>
> test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 73:
> 
>> 71:                 && !Arrays.equals(origKey.getEncoded(), copyKey.getEncoded())
>> 72:                 && origKey.hashCode() != copyKey.hashCode()) {
>> 73:             throw new RuntimeException("Key inequality found");
> 
> Check the format equality as well?

Should
 be || instead of &&?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3490



More information about the security-dev mailing list