RFR: 8264208: Console charset API [v8]

Naoto Sato naoto at openjdk.java.net
Thu Apr 15 18:36:40 UTC 2021


On Thu, 15 Apr 2021 14:17:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added @see links.
>
> src/java.base/share/classes/java/io/Console.java line 397:
> 
>> 395:     /**
>> 396:      * Returns the {@link java.nio.charset.Charset Charset} object used in
>> 397:      * the {@code Console}.
> 
> What would you think about re-phrasing the first sentence to use "for the Console" rather than "in the Console".

Changed to "for the Console", as well as `@return`.

> src/java.base/share/classes/java/lang/System.java line 123:
> 
>> 121:      *
>> 122:      * @see Console#charset()
>> 123:      * @see Console#reader()
> 
> What would you think about changing the example in InputStreamReader class description as part of this?

Replaced `System.in` with generic `anInputStream`, as changing `new InputStreamReader` with `Console.reader()` would defy the purpose of the example.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3419



More information about the security-dev mailing list