RFR: 8264208: Console charset API [v9]

Naoto Sato naoto at openjdk.java.net
Fri Apr 16 18:58:35 UTC 2021


On Fri, 16 Apr 2021 18:15:41 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Modified javadocs per suggestions.
>
> src/java.base/share/classes/java/io/InputStreamReader.java line 48:
> 
>> 46:  * <p> For top efficiency, consider wrapping an InputStreamReader within a
>> 47:  * BufferedReader.  For example:
>> 48:  *
> 
> Oddly, none of the reference in this class to the default charset are links to Charset.defaultCharset().
> That would be a useful addition, either in the class javadoc or in the 1-arg constructor that uses the default charset.

Thanks, Roger. Both are good suggestions. Will incorporate them into the next iteration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3419



More information about the security-dev mailing list