RFR: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

[Jamil Nimeh]

On Fri, 23 Apr 2021 20:51:19 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Hello All,
> 
> Could you please review the fix for the JDK-8241248?
> The issue happens during the TLSv1.3 handshake without server stateless session resumption in case of server receives several parallel requests with the same pre_shared_key.
> The main idea of the fix is to remove resuming session from the session cache in the early stage.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8241248
> Webrev: http://cr.openjdk.java.net/~abakhtin/8241248/webrev.v0/
> 
> The test from the bug report using OpenSSL is passed ( -Djdk.tls.server.enableSessionTicketExtension=false )
> javax/net/ssl and sun/security/ssl jtreg tests passed
> 
> Regards
> Alexey

Marked as reviewed by jnimeh (Reviewer).

I think this looks good.  Thank you.
Since you've done all the work on this one, it seems fitting that you'd become the owner of the issue in JBS.  Also this might be a noreg-hard candidate since the failure is intermittent and requires putting load on a server in order to run into the issue, correct?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3664