RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

Valerie Peng valeriep at openjdk.java.net
Tue Apr 27 19:19:40 UTC 2021


On Tue, 27 Apr 2021 18:49:30 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_util.c line 189:
>> 
>>> 187:  * returnValue is CKR_OK. Otherwise, it returns the returnValue as a jLong.
>>> 188:  *
>>> 189:  * @param env - used to call JNI funktions and to get the Exception class
>> 
>> NitPick: here and above some German seems to have slipped in. I think we want "functions"
>
> I didn't notice the German, just copy-n-paste. Will fix the typos.

Other PKCS#11 JNI sources have the same German typos, I prefer to leave them out of this. Will fix them when they are touched in other fixes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3709



More information about the security-dev mailing list