RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)

[Maurizio Cimadamore]

On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-412 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/412
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ResourceScope.java line 205:
> 
>> 203:      * until all the resource scope handles acquired from it have been {@link #release(Handle)} released}.
>> 204:      * @return a resource scope handle.
>> 205:      */
> 
> Given recent changes, it might be good to generalise the opening sentence here. Maybe :
>  " Acquires a resource scope handle associated with this resource scope. If the resource scope is explicit ... "   Or some such.

I'm afraid I don't get this comment ;-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/3699