RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

Valerie Peng valeriep at openjdk.java.net
Thu Apr 29 21:35:53 UTC 2021


On Tue, 27 Apr 2021 18:46:21 GMT, Greg Rubin <github.com+829871+SalusaSecondus at openjdk.org> wrote:

>> For this particular call, the pValue field is null, it's meant to query the exact length of the specified attribute. Thus, CKR_BUFFER_TOO_SMALL should not be returned. 
>> Afterwards, we then allocate the buffer based on this queried result, so CKR_BUFFER_TOO_SMALL should also not occur.
>> So, based on the current API usage, CKR_BUFFER_TOO_SMALL should not happen.
>
> All my concerns are addressed then. So, while my review doesn't count towards acceptance of this change, everything LGTM.

Thanks for your review still. Good to have an extra pair of eyes to look over the changes...

-------------

PR: https://git.openjdk.java.net/jdk/pull/3709


More information about the security-dev mailing list