RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v7]

Anthony Scarpino ascarpino at openjdk.java.net
Fri Aug 6 19:51:34 UTC 2021


On Fri, 6 Aug 2021 19:32:25 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Smita Kamath has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Merge branch 'aes-gcm' of github.com:smita-kamath/jdk into aes-gcm
>>  - Updates, comment and variable cleanup
>>  - merge rest
>>  - merge
>>  - fixes and code comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 1648:
> 
>> 1646: 
>> 1647:             ghash.doFinal(in, inOfs, inLen);
>> 1648:             return len + gctr.doFinal(in, inOfs, inLen, out, outOfs);
> 
> Why not just keep "return len + op.doFinal(in, inOfs, inLen, out, outOfs);"?

It probably got changed because I was cleaning up unused 'op' elsewhere

-------------

PR: https://git.openjdk.java.net/jdk/pull/4019



More information about the security-dev mailing list