RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java [v7]

Weijun Wang weijun at openjdk.java.net
Tue Aug 17 12:03:31 UTC 2021


On Tue, 17 Aug 2021 11:33:07 GMT, Abdul Kolarkunnu <akolarkunnu at openjdk.org> wrote:

>> ParamsTest is an interop test between keytool <-> openssl. There are some manual steps listed in jdk/sun/security/pkcs12/params/README to perform after the execution of jtreg execution. So this test is to perform that manual steps.
>
> Abdul Kolarkunnu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java

Approved. There's a tiny style issue. Fix it if you have time.

Thanks for the great work. The test is much more complete now.

test/lib/jdk/test/lib/artifacts/OpensslArtifactFetcher.java line 87:

> 85:         if(verifyOpensslVersion("/usr/bin/openssl", version)) {
> 86:             return "/usr/bin/openssl";
> 87:         } else if(verifyOpensslVersion("/usr/local/bin/openssl", version)) {

Add a space after `if` on lines 85 and 87.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4413



More information about the security-dev mailing list