RFR: 8270344: Session resumption errors [v5]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Fri Aug 20 16:48:33 UTC 2021


On Fri, 20 Aug 2021 16:31:11 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/ClientHello.java line 547:
>> 
>>> 545:                     // handshake output stream, so that the output records
>>> 546:                     // (at the record layer) have the correct version
>>> 547:                     chc.setVersion(sessionVersion);
>> 
>> The removing of the call to "setVersion()" has an impact, I think.  I think the declaration of this method could be removed in HandshakeContext class, and set the HandshakeContext.conContext.protocolVersion to HandshakeContext.maximumActiveProtocol in the  HandshakeContext.initialize() method.
>
> I've removed the (now) redundant setVersion(..) method.
> 
> With respect to initialize() method we already set  HandshakeContext.conContext.protocolVersion  to HandshakeContext.maximumActiveProtocol in the case of a new session. Is that what you were aiming at ?
> https://github.com/openjdk/jdk/blob/1ea437a4b87381b558cf8157ac52fc03e37ac507/src/java.base/share/classes/sun/security/ssl/HandshakeContext.java#L261

Yes.  Thank you!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5110


More information about the security-dev mailing list