RFR: 8246797: A convenient method to read OPTIONAL element [v2]

Valerie Peng valeriep at openjdk.java.net
Tue Aug 24 17:16:32 UTC 2021


On Tue, 24 Aug 2021 17:04:01 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/share/classes/sun/security/util/DerValue.java line 319:
> 
>> 317: 
>> 318:     /**
>> 319:      * Wraps a byte array at a single DerValue.
> 
> nit: at=>as

There is already a pkg private constructor with exactly same list of arguments. What is the reason for adding a new public static method vs change the pkg private constructor to public?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5221



More information about the security-dev mailing list